Skip to content

Conversation

@MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Dec 24, 2024

Description

This pull request includes several updates to the Action-Test workflow configuration in the .github/workflows/Action-Test.yml file. The main changes involve updating the token and credentials handling to use matrix strategies for better flexibility and security.

Improvements to token handling:

  • Updated the token reference from TEST_PAT to TEST_USER_PAT in the Action-Test job.
  • Changed the token reference for ActionTestWithFGPAT to use a matrix strategy, allowing for different tokens based on the matrix configuration.

Enhancements to GitHub App credentials:

  • Updated the GitHub App credentials handling in the ActionTestWithGitHubApp job to use a matrix strategy, allowing for different client IDs and private keys based on the matrix configuration. [1] [2]

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@MariusStorhaug MariusStorhaug self-assigned this Dec 24, 2024
@MariusStorhaug MariusStorhaug merged commit b2cd139 into main Dec 24, 2024
8 checks passed
@MariusStorhaug MariusStorhaug deleted the tests branch December 24, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants