AMM-1450 |Records still visible in MO worklist after unallocating all records

[srishtigrp78]

📋 Description

JIRA ID: 1450
Records still visible in MO worklist after unallocating all records
Please provide a summary of the change and the motivation behind it. Include relevant context and details.

---

✅ Type of Change

• 🐞 Bug fix (non-breaking change which resolves an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 🛠 Refactor (change that is neither a fix nor a new feature)
• ⚙️ Config change (configuration file or build script updates)
• 📚 Documentation (updates to docs or readme)
• 🧪 Tests (adding new or updating existing tests)
• 🎨 UI/UX (changes that affect the user interface)
• 🚀 Performance (improves performance)
• 🧹 Chore (miscellaneous changes that don't modify src or test files)

---

ℹ️ Additional Information

Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.

Summary by CodeRabbit

• New Features

  • Added support for filtering allocated outbound calls by preferred language for both mother and child records.
  • Enhanced role-based handling to include an additional role for managing call allocations.

• Refactor

  • Improved clarity and maintainability of the call allocation process, including clearer date handling and updated exception messages.

[coderabbitai]

Walkthrough

Two new query methods were added to the OutboundCallsRepo interface to support language-based filtering of allocated calls for specific user roles and record types. The moveAllocatedCallsToBin method in CallAllocationImpl was refactored to utilize these new queries for the "MO" role, with improved date handling and clearer role-based logic for moving calls to the bin.

Changes

File(s)	Change Summary
src/main/java/com/iemr/ecd/repo/call_conf_allocation/OutboundCallsRepo.java	Added two query methods for paginated retrieval of allocated calls by user, role ("MO"), record type (Mother/Child), and language.
src/main/java/com/iemr/ecd/service/call_conf_allocation/CallAllocationImpl.java	Refactored moveAllocatedCallsToBin to use new repo methods for "MO" role, clarified date handling, and streamlined role checks.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CallAllocationService
    participant OutboundCallsRepo
    participant MotherRecordRepo
    participant ChildRecordRepo

    User->>CallAllocationService: moveAllocatedCallsToBin(callAllocationDto)
    CallAllocationService->>OutboundCallsRepo: getAllocatedRecordsUserByRecordTypeAndPhoneTypeMotherMO/ChildMO(...)
    OutboundCallsRepo-->>CallAllocationService: Page<OutboundCalls>
    CallAllocationService->>MotherRecordRepo: updateAllocationStatus(motherIds)
    CallAllocationService->>ChildRecordRepo: updateAllocationStatus(childIds)
    CallAllocationService-->>User: Success JSON response

Loading

Poem

A hop, a skip, a query anew,
Now language and roles filter what we do.
MO mothers and children, sorted with care,
Allocation moves swift as springtime air.
With each call binned, the records align—
A rabbit’s work, efficient and fine!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between d09e132 and 7568777.

📒 Files selected for processing (2)

• src/main/java/com/iemr/ecd/repo/call_conf_allocation/OutboundCallsRepo.java (1 hunks)
• src/main/java/com/iemr/ecd/service/call_conf_allocation/CallAllocationImpl.java (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (java)

🔇 Additional comments (9)

src/main/java/com/iemr/ecd/repo/call_conf_allocation/OutboundCallsRepo.java (2)

367-374: New query method for retrieving MO-specific mother records is well-implemented

This method correctly extends the repository's functionality to retrieve mother records allocated to a Medical Officer, filtered by preferred language. The implementation is consistent with existing query patterns in the codebase.

---

375-380: New query method for retrieving MO-specific child records is well-implemented

This method correctly extends the repository's functionality to retrieve child records allocated to a Medical Officer, filtered by preferred language. The implementation is consistent with existing query patterns in the codebase.

src/main/java/com/iemr/ecd/service/call_conf_allocation/CallAllocationImpl.java (7)

585-587: LGTM: Line spacing is appropriate

Proper spacing between methods improves readability.

---

589-604: The input validation and timestamp handling looks good

Input validation is thorough and the timestamp handling has been improved with explicit time formats ("T00:00:00+05:30" and "T23:59:59+05:30"). This provides consistent date range boundaries for queries.

---

605-630: Well-structured role-based handling for mother records

The code now properly handles different roles including the newly added MO role for mother records. The nested if-else structure makes the logic clearer and the code properly utilizes the new repository method for MO users.

---

631-651: Well-structured role-based handling for child records

The code now properly handles different roles including the newly added MO role for child records. The nested if-else structure makes the logic clearer and the code properly utilizes the new repository method for MO users.

---

652-672: The record processing logic is robust

The logic for resetting allocation fields and handling introductory calls is well-implemented. It properly collects mother and child IDs for bulk updates, which is an efficient approach.

---

673-687: Batch operations and error handling are well-implemented

Using batch operations (saveAll) for updating records is efficient. The error messages are clear and provide enough information for troubleshooting.

---

689-696: Response handling and exception wrapping look good

The method returns a clear success message and properly wraps exceptions in a custom ECDException.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud