Skip to content

feat: ensure url doesn't have version. upgrade version #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drtechie merged 3 commits into from
May 19, 2025
Merged

feat: ensure url doesn't have version. upgrade version #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8066d98
feat: ensure url doesn't have version. upgrade version
drtechie May 15, 2025
dc39fe4
fix: cleanup env variables; delete unused _dev, _uat, _test env files
drtechie May 17, 2025
d35c8e1
fix: update names of the services in pom.xml files
drtechie May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
</parent>
<groupId>com.iemr.ecd</groupId>
<artifactId>ecd-api</artifactId>
<version>0.0.1</version>
<version>3.1.0</version>
<packaging>war</packaging>
<name>ecd-api</name>
<name>ECD-API</name>
<description>ECD project</description>
<properties>
<environment>${ENV_VAR}</environment>
Expand Down Expand Up @@ -249,7 +249,7 @@


<build>
<finalName>ecdapi-v3.0.0</finalName>
<finalName>${artifactId}-${version}</finalName>
<plugins>

<plugin>
Expand Down Expand Up @@ -336,6 +336,20 @@
</target>
</configuration>
</execution>
<execution>
<phase>process-resources</phase>
<goals>
<goal>run</goal>
</goals>
<id>clean-property-files</id>
<configuration>
<target>
<delete>
<file file="${source-properties}" />
</delete>
</target>
</configuration>
</execution>
</executions>
</plugin>

Expand Down
1 change: 1 addition & 0 deletions src/main/environment/ecd_ci.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ beneficiaryEditUrl =@env.COMMON_API@/beneficiary/update


#ELK logging file name
logging.path=logs/
logging.file.name=@env.ECD_API_LOGGING_FILE_NAME@


Expand Down
24 changes: 0 additions & 24 deletions src/main/environment/ecd_dev.properties
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions src/main/environment/ecd_example.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,7 @@ beneficiaryEditUrl =https:localhost:8083/beneficiary/update
springdoc.api-docs.enabled=true
springdoc.swagger-ui.enabled=true

jwt.secret=my-32-character-ultra-secure-and-ultra-long-secret

@coderabbitai coderabbitai Bot May 19, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Avoid committing real secrets in example configs.
The example file contains a concrete JWT secret. Replace it with a clear placeholder (e.g., YOUR_JWT_SECRET_HERE) and document that a real secret must be provided during deployment to prevent accidental exposure.

🤖 Prompt for AI Agents 
In src/main/environment/ecd_example.properties at line 23, replace the concrete
JWT secret value with a clear placeholder like YOUR_JWT_SECRET_HERE. Add a
comment or note indicating that a real secret must be provided during deployment
to avoid accidental exposure of sensitive information.

#If both properties are set, only logging.file.name takes effect.
logging.path=logs/
logging.file.name=logs/ecd-api.log
24 changes: 0 additions & 24 deletions src/main/environment/ecd_test.properties
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions src/main/environment/ecd_uat.properties
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@ logging.level.web=INFO
logging.level.org.springframework.web=INFO
logging.level.org.hibernate=INFO

#If both properties are set, only logging.file.name takes effect.
logging.path=logs/
logging.file.name=logs/ecd-api.log

## multipart file size
spring.http.multipart.max-request-size=10MB
spring.http.multipart.max-file-size=10MB
Expand Down
4 changes: 4 additions & 0 deletions src/main/webapp/WEB-INF/jboss-web.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<jboss-web>
<context-root>/ecd-api</context-root>
</jboss-web>