Update ecd_ci.properties

[srinuatpiramal]

📋 Description

JIRA ID:

Please provide a summary of the change and the motivation behind it. Include relevant context and details.

---

✅ Type of Change

• 🐞 Bug fix (non-breaking change which resolves an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 🛠 Refactor (change that is neither a fix nor a new feature)
• ⚙️ Config change (configuration file or build script updates)
• 📚 Documentation (updates to docs or readme)
• 🧪 Tests (adding new or updating existing tests)
• 🎨 UI/UX (changes that affect the user interface)
• 🚀 Performance (improves performance)
• 🧹 Chore (miscellaneous changes that don't modify src or test files)

---

ℹ️ Additional Information

Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.

Summary by CodeRabbit

• Configuration Updates
  • Updated beneficiary registration and edit URLs to use a standardized API base URL reference
  • No changes to logging file name configuration

[coderabbitai]

Walkthrough

The pull request involves updating the configuration properties in the ecd_ci.properties file. The changes focus on modifying the URLs for beneficiary registration and editing by replacing the COMMON_API_BASE_URL environment variable with COMMON_API. This adjustment standardizes the API base URL reference for beneficiary-related operations while maintaining the existing endpoint paths for creating and updating beneficiaries.

Changes

File	Change Summary
src/main/environment/ecd_ci.properties	- Updated registerBeneficiaryUrl from @env.COMMON_API_BASE_URL@/beneficiary/create to @env.COMMON_API@/beneficiary/create - Updated beneficiaryEditUrl from @env.COMMON_API_BASE_URL@/beneficiary/update to @env.COMMON_API@/beneficiary/update

Poem

🐰 Hopping through configs with glee,
URLs dancing, setting them free!
From BASE_URL to COMMON_API,
Beneficiary paths find their way,
A rabbit's config update, hip-hooray! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/main/environment/ecd_ci.properties (2)

17-17: Remove extra space after property name

There's an extra space between beneficiaryEditUrl and = which makes the formatting inconsistent with other properties in the file.

-beneficiaryEditUrl =@env.COMMON_API@/beneficiary/update
+beneficiaryEditUrl=@env.COMMON_API@/beneficiary/update

---

14-17: Document environment variable changes

Consider adding documentation that explains:

1. The rationale behind standardizing to COMMON_API
2. The expected format/structure of the COMMON_API environment variable
3. Migration steps for other services that might be using these URLs

This will help maintain consistency across the system and ease future maintenance.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 71fb761 and f9e6a75.

📒 Files selected for processing (1)

• src/main/environment/ecd_ci.properties (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (java)

🔇 Additional comments (2)

src/main/environment/ecd_ci.properties (2)

20-20: LGTM!

The logging file name configuration is properly formatted and maintained.

---

14-14: Verify environment variable configuration

The change from COMMON_API_BASE_URL to COMMON_API environment variable might impact the deployment pipeline. Please ensure:

1. The COMMON_API environment variable is properly configured in CI/CD pipelines
2. The value includes the complete base URL structure required for the API endpoint

Let's check for any other occurrences of these environment variables in the codebase: