Skip to content

fix: Enhance PR file change detection in lint_audit workflow #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drtechie merged 1 commit into from
Oct 25, 2024
Merged

fix: Enhance PR file change detection in lint_audit workflow #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/lint_audit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,12 @@ jobs:
id: changed-files
run: |
if [ "${{ github.event_name }}" == "pull_request" ]; then
echo "Pull Request detected"
echo "PR Head SHA: ${{ github.event.pull_request.head.sha }}"
echo "github.sha: ${{ github.sha }}"
git fetch origin ${{ github.base_ref }} || git fetch --unshallow
git diff --name-only origin/${{ github.base_ref }}...${{ github.sha }} > changed_files.txt || echo "Unable to determine changed files"
git fetch origin ${{ github.event.pull_request.head.sha }} || git fetch --unshallow
Comment on lines 48 to +49

@coderabbitai coderabbitai Bot Oct 25, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Improve error handling in git fetch operations.

The current implementation uses || git fetch --unshallow as a fallback, but this could mask other types of failures.

Consider using explicit error handling:

-            git fetch origin ${{ github.base_ref }} || git fetch --unshallow
-            git fetch origin ${{ github.event.pull_request.head.sha }} || git fetch --unshallow
+            if ! git fetch origin ${{ github.base_ref }}; then
+              if ! git fetch --unshallow; then
+                echo "Error: Failed to fetch ${{ github.base_ref }}"
+                exit 1
+              fi
+            fi
+            if ! git fetch origin ${{ github.event.pull_request.head.sha }}; then
+              if ! git fetch --unshallow; then
+                echo "Error: Failed to fetch PR head SHA"
+                exit 1
+              fi
+            fi
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
git fetch origin ${{ github.base_ref }} || git fetch --unshallow
git diff --name-only origin/${{ github.base_ref }}...${{ github.sha }} > changed_files.txt || echo "Unable to determine changed files"
git fetch origin ${{ github.event.pull_request.head.sha }} || git fetch --unshallow
if ! git fetch origin ${{ github.base_ref }}; then
if ! git fetch --unshallow; then
echo "Error: Failed to fetch ${{ github.base_ref }}"
exit 1
fi
fi
if ! git fetch origin ${{ github.event.pull_request.head.sha }}; then
if ! git fetch --unshallow; then
echo "Error: Failed to fetch PR head SHA"
exit 1
fi
fi

git diff --name-only origin/${{ github.base_ref }}...${{ github.event.pull_request.head.sha }} > changed_files.txt || echo "Unable to determine changed files"
elif [ "${{ github.event_name }}" == "push" ]; then
git diff --name-only ${{ github.event.before }} ${{ github.sha }} > changed_files.txt || echo "Unable to determine changed files"
else
Expand Down