ci: trigger nightly path filter on any Cargo.toml change#5843
Merged
ci: trigger nightly path filter on any Cargo.toml change#5843
Conversation
The bare `Cargo.toml` glob only matched the workspace root, so PR PRQL#5834 (which only touched `prqlc/prqlc/Cargo.toml`) skipped `test-deps-min-versions` and the chrono = "0.4" minimum-version regression slipped through. Switch to `**/Cargo.toml` so any workspace member's manifest sets `nightly = true`. Co-Authored-By: Claude <noreply@anthropic.com>
prql-bot
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nightly:path filter intests.yamlhadCargo.toml(root-only) where it should have had**/Cargo.toml. PR #5834 only touchedprqlc/prqlc/Cargo.toml, sotest-deps-min-versionswas skipped on its CI run, letting thechrono = "0.4"minimum-version regression land on main (now being fixed in #5841).Audited the rest of the
changes:block — every other filter that should match nested files already uses a**glob.Cargo.lock(only one in the workspace),rust-toolchain.toml, and the bareTaskfile.yamlin the devcontainer filters (intentionally root-only) are unchanged.