feat: add oracle_sql dialect support#5821
Conversation
prql-bot
left a comment
There was a problem hiding this comment.
The cli::test::get_targets snapshot will fail in CI. #[strum(serialize_all = "lowercase")] on Dialect lowercases variants without adding separators — OracleSql serializes as oraclesql, not oracle_sql. Running prqlc list-targets against this branch locally outputs sql.oraclesql, so the expected line added at cli/test.rs:89 won't match.
That also makes the CLI target name diverge from the Elixir binding atom :oracle_sql.
Two ways to reconcile:
- Rename the variant
OracleSql→Oracle(matches the existingPostgres,Snowflake,Redshiftconvention; CLI target becomessql.oracle, Elixir atom becomes:oracle). Updates needed indialect.rs,cli/test.rs,tests/integration/sql.rs, and the Elixir binding's atom + match arm. - Keep
OracleSqland add#[strum(serialize = "oracle_sql")]on the variant so the user-facing name staysoracle_sql; the snapshot atcli/test.rs:89then stays correct.
A couple of items missing outside the diff — happy to push a commit for these once the naming question is settled:
web/book/src/project/target.mdlists supported/unsupported dialects; Oracle isn't in either list.prqlc/bindings/elixir/lib/prql.ex:42-43docstring enumerates accepted atoms;:oracle_sqlis missing there too.
prql-bot
left a comment
There was a problem hiding this comment.
The rename to Dialect::Oracle is missed in the integration test, breaking the build (test-rust (wasm32...) is already failing on this commit). One inline suggestion below.
Co-authored-by: prql-bot <107324867+prql-bot@users.noreply.github.com>
|
@prql-bot can you add a short note to the docs etc re having a very early version of Oracle dialect? |
Adds a short note next to `sql.oracle` in the dialects list and a changelog entry, clarifying that the initial Oracle dialect only forces identifier quoting and most other features fall back to generic SQL. Requested by @max-sixty in PRQL#5821 (comment). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Added a short note in bef16d4 — the dialects list in |
Add basic support for Oracle SQL dialect to force quotes on identifiers.