fix: correct aarch64 target path in Java cross-compilation script#5781
Merged
fix: correct aarch64 target path in Java cross-compilation script#5781
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Same copy-paste bug as the active aarch64-linux block — referenced x86_64-apple-darwin instead of aarch64-apple-darwin. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prqlc/bindings/java/cross.shwhere lines 44-45 referencedx86_64-unknown-linux-gnuinstead ofaarch64-unknown-linux-gnuafter cross-compiling for the aarch64 targetlibprql_java-linux-aarch64.so) to actually contain an x86_64 binary, since it was copied from the wrong target directoryTest plan
../target/aarch64-unknown-linux-gnu/releasefor both thelsandcpcommands on lines 44-45🤖 Generated with Claude Code