fix: date.trunc returns error for SQLite instead of invalid SQL#5733
Merged
fix: date.trunc returns error for SQLite instead of invalid SQL#5733
Conversation
SQLite doesn't have a DATE_TRUNC function, but prqlc was generating
`DATE_TRUNC('day', event_time)` when targeting SQLite. This adds
`let trunc = unit column -> null` to the sqlite.date module, following
the same pattern used for date.diff on unsupported dialects.
Closes #5730
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DATE_TRUNCfunction, but prqlc was generatingDATE_TRUNC('day', event_time)when targeting SQLitelet trunc = unit column -> nullto thesqlite.datemodule instd.sql.prql, following the same pattern used fordate.diffon unsupported dialectsdate_trunc_unsupported_dialectsto verify SQLite correctly returns an errorTest plan
cargo insta test -p prqlc --test integration -- date_truncpasses (7 tests)task prqlc:pull-requesttest suite passesCloses #5730
🤖 Generated with Claude Code