fix: Handle lineage correctly when group pipeline simplifies to non-TransformCall#5584
Merged
fix: Handle lineage correctly when group pipeline simplifies to non-TransformCall#5584
Conversation
…ransformCall Fixes PRQL#5092: ICE when using group with only sort (no take). When `sort_undone` is true (inside a group), sorts are dropped. The original GROUP lineage was preserved with stale target_id references to expressions that no longer exist in the tree. This caused `lookup_cid` in lowering to fail with error code 3870. The fix conditionally chooses the lineage: - If pipeline remains a TransformCall (e.g., group + aggregate), use GROUP lineage - If pipeline simplified to non-TransformCall (e.g., sort dropped), use pipeline lineage 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5092: ICE when using
groupwith onlysort(notake).sort_undoneis true (inside a group), sorts are droppedtarget_idreferences to expressions that no longer exist in the treelookup_cidin lowering to fail with error code 3870The fix conditionally chooses the lineage:
TransformCall(e.g.,group + aggregate), use GROUP lineage which includesbycolumnsTransformCall(e.g., sort dropped), use pipeline lineage to avoid stale referencesTest plan
test_group_with_only_sorttest case verifying the fix🤖 Generated with Claude Code