Skip to content

build: Update rust toolchain version#5536

Merged
prql-bot merged 2 commits intomainfrom
update_rust_toolchain_action
Oct 31, 2025
Merged

build: Update rust toolchain version#5536
prql-bot merged 2 commits intomainfrom
update_rust_toolchain_action

Conversation

@prql-bot
Copy link
Copy Markdown
Collaborator

Automatic change by the update-rust-toolchain Github Action.

Github Actions will not run workflows on pull requests which are opened by a GitHub Action.

For examples on how to run workflows on this pr, please go to the readme.

@prql-bot prql-bot enabled auto-merge (squash) October 31, 2025 10:57
@max-sixty
Copy link
Copy Markdown
Member

@claude can you fix?

@claude
Copy link
Copy Markdown

claude Bot commented Oct 31, 2025

Claude finished @max-sixty's task —— View job


✅ Task Complete

Fixed the Rust toolchain update! The issue was that Rust 1.90.0 introduced a stricter unused_parens lint that treats unnecessary parentheses around closure bodies as errors (when using -Dwarnings as this project does).

Changes Made

  • Fixed 7 clippy warnings in prqlc/bindings/prqlc-python/src/lib.rs
  • Removed unnecessary parentheses around closure bodies in .map_err() calls (lines 17, 24, 31, 39, 55, 66, 74)

Testing

  • 597 tests passed locally with task test-all
  • ✅ Changes committed and pushed to the PR branch
  • ✅ CI should now pass with Rust 1.90.0

Details

The Rust toolchain was updated from 1.89.0 to 1.90.0 in rust-toolchain.toml. Rust 1.90.0's clippy has a more strict lint that flags code like:

.map_err(|err| (PyErr::new::<...>(...)))

as having unnecessary parentheses. The fix is simply:

.map_err(|err| PyErr::new::<...>(...))

--- | View PR branch | View commit

Rust 1.90.0 introduced a stricter unused_parens lint that flags
unnecessary parentheses around closure bodies. This change removes
the extra parentheses from 7 map_err() closures in prqlc-python.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Maximilian Roos <max-sixty@users.noreply.github.com>
@prql-bot prql-bot merged commit d7ceed5 into main Oct 31, 2025
79 checks passed
@prql-bot prql-bot deleted the update_rust_toolchain_action branch October 31, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants