Merged
Conversation
Fixes s-strings terminating when they contain double quote.
Member
|
thanks @priithaamer ! can we avoid doing a full integration test for each change if possible? hopefully this can just be a small inline insta test (ideally same with #5495) (also OK if we merge, release, and then I'll ask Claude to make these smaller — wdyt?) |
Member
|
I made the changes — it's at max-sixty@7a821b8a can you enable "Allow edits from maintainers" so I can push to this branch? |
…ping Replace the comprehensive integration test with a focused inline test that verifies escaped quotes in s-strings round-trip correctly through parse and format. The lexer already has coverage for tokenization of escaped quotes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
Hey, thanks for the changes, i merged them myself. Should be less trouble for you. Totally fine to use the inline tests -- i was a bit unsure about integration tests as well. This and #5495 are last remaining blockers for us to upgrade from 0.13.4 and close several issues / improvements in our product. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to fix regression #5496 that was working in 0.13.4