Conversation
… from the matching table_ref It was done by converting the CTE's table id into an RIId for now, but those can differ in case some CTEs get erased. This resulted in the wrong CId redirect being updated. Fixing this by finding a relation instance whose table_ref's source matches the CTE's table_id instead. Follow up of PRQL#5464 Signed-off-by: Luka Peschke <mail@lukapeschke.com>
Contributor
Author
|
Hi @max-sixty, I've missed this subtelty in #5464 , my bad 😕 could you please have a look ? |
Member
|
nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was done by converting the CTE's table id into an RIId for now, but those can differ in case some CTEs get erased. This resulted in the wrong CId redirect being updated.
Fixing this by finding a relation instance whose table_ref's source matches the CTE's table_id instead.
Follow up of #5464