Skip to content

build: Enable resolver v3 with MSRV testing workaround #5444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-sixty merged 2 commits into from
Sep 25, 2025
Merged

build: Enable resolver v3 with MSRV testing workaround #5444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8d8053
build: Enable resolver v3 with MSRV testing workaround
max-sixty Sep 25, 2025
14d777c
Merge branch 'main' into resolver-v3-with-msrv-fix
max-sixty Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,12 @@ jobs:
steps:
- name: 📂 Checkout code
uses: actions/checkout@v5
- name: Prepare for MSRV testing
# Resolver v3 requires Rust 1.84+ to parse the Cargo.toml, but our library MSRV is 1.75.
# We temporarily downgrade to resolver v2 for MSRV testing.
run: |
echo "Patching Cargo.toml for MSRV testing (resolver v3 requires Rust 1.84+)"
sed -i 's/resolver = "3"/resolver = "2"/g' Cargo.toml
- uses: baptiste0928/cargo-install@v3
with:
crate: cargo-msrv
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ members = [
"prqlc/prqlc/examples/compile-files", # An example
"web/book",
]
resolver = "2"
resolver = "3"

[workspace.package]
authors = ["PRQL Developers"]
Expand Down
Loading