chore: set rust linker on win64, fix build crash#5345
Conversation
|
bleh, no luck. we could just comment out the windows tests until it's fixed upstream? |
|
It did actually fix the linker-related crash, but it didn't fix the other issues :( One is weird -- in The other one in test-js seems maybe that something (wasm-pack) was omitted from the runner image. I wonder if it's possible to add that back in somehow. Still looking into that one. |
oh nice! and the build now passes on windows but yeah then the insta issue is surprising — it says it's installed: https://github.com/PRQL/prql/actions/runs/16012029427/job/45171587927?pr=5345#step:7:12 |
|
Is the insta issue possibly related to the cache in some way? I wonder how to reset / clean out that cache, maybe it needs a fresh install for the latest runner. I fiddled with the matrix settings for test-js and test-rust-main so that the failing Windows tests there won't stop the whole pipeline. Now, check-ok-to-merge is good with ignoring the failed Windows tests. I'm going to go ahead and merge this now, since it's better than before. It's still worth trying a bit more to fix the failing tests though. |
I did a little google searching of the recently appearing Windows build failures and found actions/runner-images#12432, which led to rust-lang/rust#141626 (comment). Let's see if this fixes the issue.