Skip to content

feat(prqlc): extract SQL column names from s-string tables when possible#5310

Merged
max-sixty merged 1 commit intoPRQL:mainfrom
lukapeschke:extract-column-names-s-strings
May 27, 2025
Merged

feat(prqlc): extract SQL column names from s-string tables when possible#5310
max-sixty merged 1 commit intoPRQL:mainfrom
lukapeschke:extract-column-names-s-strings

Conversation

@lukapeschke
Copy link
Copy Markdown
Contributor

relates to #5302

relates to PRQL#5302

Signed-off-by: Luka Peschke <mail@lukapeschke.com>
@lukapeschke
Copy link
Copy Markdown
Contributor Author

This is an attempt at simplifying the SQL query in #5302 . It does not remove unwanted columns but at least makes the final SQL query more explicit

@max-sixty
Copy link
Copy Markdown
Member

great, this looks good; I agree the SQL is better! thanks @lukapeschke

@max-sixty max-sixty merged commit 96f3df8 into PRQL:main May 27, 2025
35 of 36 checks passed
@lukapeschke lukapeschke deleted the extract-column-names-s-strings branch May 28, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants