Fix issues #514, #516, #517, #518 - #608
Closed
rohitkumarnaidu wants to merge 6 commits into
Closed
Conversation
- PRODHOSH#514: Fix prefer-const lint warning in profile-export.ts - PRODHOSH#516: Replace any types with strict interfaces in [username]/page.tsx - PRODHOSH#517: Replace any casts with explicit checks in explore/page.tsx - PRODHOSH#518: Extract hardcoded GitHub API URL into GITHUB_API_URL constant
Contributor
Welcome to OSSfolio, @rohitkumarnaidu! 🎉Thank you for opening this pull request and contributing to the open-source community! 🚀 To ensure a smooth review process, please make sure you have:
We will review your PR as soon as possible. Happy coding! 💻✨ |
Contributor
|
Important Review skippedToo many files! This PR contains 172 files, which is 72 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (172)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe changes centralize GitHub API URL construction across REST and GraphQL integrations, tighten profile and badge typing, improve organization/contributor leaderboard row handling, and remove an unused heatmap variable. ChangesGitHub endpoint centralization
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/app/`[username]/page.tsx:
- Around line 187-188: Replace the random ID generation in the pinned repository
mapping within ProfileView with the repository’s stable GraphQL ID. Select that
ID in the GraphQL query, include it in the mapped node type and output shape,
and keep the same field shape aligned with the API/settings contract and
persisted pinned_repos data.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 4820597f-9c0a-4bd9-82e8-59f0b1fafe85
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (10)
src/app/[username]/opengraph-image.tsxsrc/app/[username]/page.tsxsrc/app/api/profile/sync/route.tssrc/app/compare/page.tsxsrc/app/explore/page.tsxsrc/lib/digest.tssrc/lib/github.tssrc/lib/org-data.tssrc/lib/profile-data.tssrc/lib/profile-export.ts
💤 Files with no reviewable changes (1)
- src/lib/profile-export.ts
- Update mock-supabase.mjs to return PGRST116 code for 406 empty responses - Add catch-all /api route for 404 JSON responses - Fix strict mode and hidden element locator violations in critical-paths.spec.ts - Refactor pinned items ID to use databaseId from GraphQL (CodeRabbit feedback)
Owner
|
@rohitkumarnaidu what is this? u changed 172 files? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #514, #516, #517, #518.
Summary by CodeRabbit