Skip to content

Add new terms#430

Open
alaupin-ipsl wants to merge 3 commits intoPCMDI:esgvoc_devfrom
alaupin-ipsl:esgvoc_dev
Open

Add new terms#430
alaupin-ipsl wants to merge 3 commits intoPCMDI:esgvoc_devfrom
alaupin-ipsl:esgvoc_dev

Conversation

@alaupin-ipsl
Copy link
Copy Markdown

No description provided.

@ltroussellier
Copy link
Copy Markdown
Collaborator

@znicholls i presume the failing CI are not related, but just to be sure,i ll wait for your confirmation to merge in esgvoc_dev

@znichollscr
Copy link
Copy Markdown
Collaborator

@znicholls i presume the failing CI are not related

Let's remove all the CI files in the esgvoc related branches, they will never work in these branches

{
"@context": "000_context.jsonld",
"id": "ceds-cmip-2025-04-18-supplemental",
"type": "source",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These input4MIPs CVs are not like any of the data models in esgvoc. I'm not 100% sure about what to do about this, but I think we might need a new pydantic model, ForcingProvider? It's a mess though, because what input4MIPs calls a source is actually the combination of an organisation and a version (and a whole bunch of other attributes that either need their own CV or esgvoc should just ignore entirely). Maybe that's the best way to represent this?

Categorising these as what esgvoc calls a source is definitely wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants