Skip to content

[SECURITY] Harden GitHub Workflows#10

Merged
John McCall (lowlydba) merged 2 commits intomainfrom
306-devops-create-omf-ruleset-for-all-public-repos
Apr 9, 2026
Merged

[SECURITY] Harden GitHub Workflows#10
John McCall (lowlydba) merged 2 commits intomainfrom
306-devops-create-omf-ruleset-for-all-public-repos

Conversation

@lowlydba
Copy link
Copy Markdown
Contributor

@lowlydba John McCall (lowlydba) commented Apr 9, 2026

Resolves zizmor 🌈 findings.

Going forward, these zizmor checks will be enforced by OMF Security Checks, which is now a required workflow for this, and all, public repos.

Note

The workshop staging deploy was already not working as intended, and fixing that is out of scope for this PR.

Signed-off-by: John McCall <john@overturemaps.org>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

🚀 Workshop branch preview deployed!

You can review your changes at https://staging.overturemaps.org/workshop/pr/10/index.html


♻️ Last refreshed: 2026-04-09T15:33:39Z

@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Comment thread .github/workflows/staging_deploy.yml Fixed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the repository’s automation configuration in response to zizmor findings by tightening GitHub Actions permissions and pinning third-party actions, while also adjusting Dependabot update behavior.

Changes:

  • Adds workflow concurrency controls and pins GitHub Actions to specific commit SHAs (plus disables persisted checkout credentials).
  • Refactors PR-derived values used in shell commands into environment variables and scopes elevated permissions to the deploy job.
  • Introduces a Dependabot cooldown to reduce update frequency/noise.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/staging_deploy.yml Pins actions by SHA, adds concurrency, narrows permissions, and reduces expression use inside run scripts.
.github/dependabot.yml Adds a Dependabot cooldown window for GitHub Actions updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/staging_deploy.yml
Comment thread .github/workflows/staging_deploy.yml Outdated
Signed-off-by: John McCall <john@overturemaps.org>
@lowlydba John McCall (lowlydba) merged commit 70ca029 into main Apr 9, 2026
8 checks passed
@lowlydba John McCall (lowlydba) deleted the 306-devops-create-omf-ruleset-for-all-public-repos branch April 9, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants