Skip to content
This repository was archived by the owner on Jun 3, 2021. It is now read-only.

rename 'protocol' to 'steps' and 'protocols' to 'tests'#184

Merged
soenkehahn merged 2 commits into
masterfrom
sh/renaming
Apr 2, 2019
Merged

rename 'protocol' to 'steps' and 'protocols' to 'tests'#184
soenkehahn merged 2 commits into
masterfrom
sh/renaming

Conversation

@soenkehahn
Copy link
Copy Markdown
Contributor

Closes #182.

Comment thread README.md
There is **experimental** support for recording protocols. You can either record
protocols by passing in the `--record` command line flag, or you can put
so-called holes into your protocols:
There is **experimental** support for recording tests. You can either record
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it just occurred to me that this idea might need a bit more explanation. i don't believe there are other similar tools out there that can automatically generate tests for you, so the idea of "recording tests" isn't obvious IMO.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's right. This could probably use recording snapshot tests as an analogy.

Do you think that this PR makes the readme worse? If not I would defer your concern to a different issue/PR.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no i think the change is fine, but using a more common word made it clearer to me that this was confusing. yes, i would defer to a separate PR. i can make a ticket for it.

Copy link
Copy Markdown
Contributor

@matthandlersux matthandlersux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the words "test" and "protocol" have now become meaningless to me because of https://en.wikipedia.org/wiki/Semantic_satiation :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants