fix(RequestArb): Add CMO ALL snoop blocking logic#479
Closed
yulightenyu wants to merge 4 commits intomasterfrom
Closed
fix(RequestArb): Add CMO ALL snoop blocking logic#479yulightenyu wants to merge 4 commits intomasterfrom
yulightenyu wants to merge 4 commits intomasterfrom
Conversation
When CMO ALL flushes a set, need to block same-set snoop requests:
1. If snoop comes first:
- snoop occupies MSHR
- mshrValid = true
- CMO ALL waits in sCMOREQ/sWAITMSHR until MSHR free
2. If CMO ALL comes first:
- Set cmoAllSnpBlock = true, cmoAllSnpBlockSet = current set
- RequestArb blocks any snoop with same set
- Block released when CMO ALL moves to next set
Added fields in TaskBundle:
- cmoAllSnpBlock: CMO ALL active
- cmoAllSnpBlockSet: set being flushed
good-circle
pushed a commit
to OpenXiangShan/XiangShan
that referenced
this pull request
Mar 8, 2026
This pr includes: - OpenXiangShan/CoupledL2#467 - OpenXiangShan/CoupledL2#479
good-circle
added a commit
to OpenXiangShan/XiangShan
that referenced
this pull request
Mar 9, 2026
This pr includes: - OpenXiangShan/CoupledL2#479
… RequestBuffer * cmoAllSnpBlock generated in SinkA needs to pass through RequestBuffer * RequestBuffer: RequestBuffer only samples input data when SinkA.io.task.valid is true * cmoAll: cmoAllSnpBlock must remain valid even during cycles when valid is false (CMO ALL is a multi-cycle operation)
good-circle
added a commit
to OpenXiangShan/XiangShan
that referenced
this pull request
Mar 9, 2026
This pr includes: - OpenXiangShan/CoupledL2#479
good-circle
added a commit
to OpenXiangShan/XiangShan
that referenced
this pull request
Mar 10, 2026
This pr includes: - OpenXiangShan/CoupledL2#479
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When CMO ALL flushes a set, need to block same-set snoop requests:
Added fields in TaskBundle:
- cmoAllSnpBlock: CMO ALL active
- cmoAllSnpBlockSet: set being flushed