Merged
Conversation
eb643dc to
35167dc
Compare
Spartan322
reviewed
Feb 20, 2026
Spartan322
reviewed
Feb 20, 2026
Spartan322
reviewed
Feb 20, 2026
Spartan322
reviewed
Feb 20, 2026
Spartan322
reviewed
Feb 20, 2026
Spartan322
reviewed
Feb 20, 2026
Spartan322
reviewed
Feb 20, 2026
Spartan322
reviewed
Feb 20, 2026
Spartan322
reviewed
Feb 20, 2026
0b14fe1 to
b5f395f
Compare
Spartan322
reviewed
Feb 20, 2026
2058fa3 to
6949041
Compare
Spartan322
reviewed
Feb 20, 2026
Spartan322
reviewed
Feb 20, 2026
Spartan322
reviewed
Feb 20, 2026
1041052 to
abf7261
Compare
Spartan322
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only use PROPERTY when the data must be publicly exposed and either may change or requires a chance in type (string -> string_view, vector -> span, etc).
For constant data, use const fields.
When a pointer must have a value, use a reference if possible, otherwise use
type_safe::object_ref(follow up PR coming for that).