Skip to content

Comments

Refactor const properties to fields#706

Merged
wvpm merged 1 commit intomasterfrom
refactor_const_prop_to_field
Feb 20, 2026
Merged

Refactor const properties to fields#706
wvpm merged 1 commit intomasterfrom
refactor_const_prop_to_field

Conversation

@wvpm
Copy link
Contributor

@wvpm wvpm commented Feb 20, 2026

Only use PROPERTY when the data must be publicly exposed and either may change or requires a chance in type (string -> string_view, vector -> span, etc).
For constant data, use const fields.
When a pointer must have a value, use a reference if possible, otherwise use type_safe::object_ref (follow up PR coming for that).

@Spartan322 Spartan322 added the enhancement New feature or request label Feb 20, 2026
@wvpm wvpm force-pushed the refactor_const_prop_to_field branch from eb643dc to 35167dc Compare February 20, 2026 16:32
@wvpm wvpm marked this pull request as ready for review February 20, 2026 16:33
@wvpm wvpm force-pushed the refactor_const_prop_to_field branch from 0b14fe1 to b5f395f Compare February 20, 2026 18:09
@wvpm wvpm force-pushed the refactor_const_prop_to_field branch from 2058fa3 to 6949041 Compare February 20, 2026 18:24
@wvpm wvpm enabled auto-merge February 20, 2026 18:40
@wvpm wvpm force-pushed the refactor_const_prop_to_field branch from 1041052 to abf7261 Compare February 20, 2026 19:01
@wvpm wvpm merged commit 0a08ff2 into master Feb 20, 2026
16 checks passed
@Spartan322 Spartan322 deleted the refactor_const_prop_to_field branch February 20, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request topic:codestyle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants