Skip to content

Conversation

@jonoomph
Copy link
Member

@jonoomph jonoomph commented Oct 9, 2024

Adding new Save() method to Profile class, and fix a bug with "description" getting dropped in Json() method. Added new unit tests for JSON and Save methods. Related to OpenShot/openshot-qt#5634 (new PR for Profile Editing UI)

…ption" getting dropped in Json() method. Added new unit tests for JSON and Save methods.
@jonoomph
Copy link
Member Author

jonoomph commented Oct 9, 2024

@codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 98.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.84%. Comparing base (5022ce4) to head (178cae4).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/Profiles.cpp 96.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #975      +/-   ##
===========================================
+ Coverage    54.43%   54.84%   +0.40%     
===========================================
  Files          182      182              
  Lines        16581    16638      +57     
===========================================
+ Hits          9026     9125      +99     
+ Misses        7555     7513      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonoomph jonoomph merged commit 09ca2ce into develop Oct 12, 2024
@jonoomph jonoomph deleted the choose-profile-v2 branch October 12, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants