Add Exceptions.h back to OpenShot.h #629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #629 +/- ##
===========================================
- Coverage 51.89% 50.80% -1.09%
===========================================
Files 151 148 -3
Lines 12341 11780 -561
===========================================
- Hits 6404 5985 -419
+ Misses 5937 5795 -142
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hadn't actually intended to remove
#include "Exceptions.h"fromOpenShot.h, that was an overzealous find-and-replace on my part. I'm fine withOpenShot.hbeing the only header that does automatically include it, even though for most practical applications I feelOpenShot.his now far too heavy to actually use.(Our own unit tests have stopped using it in favor of targeted includes, for example, because it'd been building in this direction for a while, and OpenCV was the tipping point on
#include "OpenShot.h"bringing in way too much stuff and excessively slowing down each source file's compilation. Still, for convenience it's "fine", and should include the exception definitions as well.)