[ModelicaSystem._run_cmd] use argument cwd of subprocess.Popen() inst…#251
Closed
syntron wants to merge 1 commit intoOpenModelica:masterfrom
Closed
[ModelicaSystem._run_cmd] use argument cwd of subprocess.Popen() inst…#251syntron wants to merge 1 commit intoOpenModelica:masterfrom
syntron wants to merge 1 commit intoOpenModelica:masterfrom
Conversation
…ead of handling directory change on our own
Contributor
|
Just FYI #249 already does this |
Contributor
Author
|
@ondras12345 no problem; could you point me to the exact commit? I checked your commit series yesterday but missed this part ... My version was just sitting in my fork since last year and included it in the updates. |
Contributor
|
It's part of this one: 401824d |
Contributor
Author
Looks fine (and is at the end the same code change ;-) ) |
Member
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use argument cwd of subprocess.Popen() instead of handling directory change on our own