Skip to content

Fix: Correct return type of get_parameters_from_json in ParameterManager.py #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Imama-Kainat wants to merge 1 commit into from
Closed

Fix: Correct return type of get_parameters_from_json in ParameterManager.py #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/workflow/ParameterManager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def save_parameters(self) -> None:
with open(self.params_file, "w", encoding="utf-8") as f:
json.dump(json_params, f, indent=4)

def get_parameters_from_json(self) -> None:
def get_parameters_from_json(self) -> dict:
"""
Loads parameters from the JSON file if it exists and returns them as a dictionary.
If the file does not exist, it returns an empty dictionary.
Expand All @@ -104,4 +104,4 @@ def reset_to_default_parameters(self) -> None:
JSON file.
"""
# Delete custom params json file
self.params_file.unlink(missing_ok=True)
self.params_file.unlink(missing_ok=True)