Skip to content

Fix fix#153

Merged
poshul merged 8 commits into
masterfrom
fix_fix
Oct 15, 2025
Merged

Fix fix#153
poshul merged 8 commits into
masterfrom
fix_fix

Conversation

@poshul
Copy link
Copy Markdown
Contributor

@poshul poshul commented Oct 15, 2025

Summary by CodeRabbit

  • Chores

    • CI matrix no longer fails fast, allowing other jobs to continue on failure.
    • Updated contrib download source to the latest release channel.
    • Upgraded bundled zlib to 1.3.1.
  • Build

    • Added a Clang-specific compiler flag to reduce noise from enum constexpr conversion warnings.
    • Simplified zlib integration by removing an extra patching step.
    • Zlib now respects BUILD_SHARED_LIBS, with conditional targets and installs.
    • Improved MSVC x64 handling and adjusted install paths.
    • Example/minigzip utilities are built only for shared-library builds.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 15, 2025

Caution

Review failed

The pull request is closed.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix_fix

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1753783 and 50e9c20.

📒 Files selected for processing (7)
  • .github/workflows/main.yml (1 hunks)
  • CMakeLists.txt (2 hunks)
  • libraries.cmake/boost.cmake (3 hunks)
  • libraries.cmake/zlib.cmake (0 hunks)
  • macros.cmake (1 hunks)
  • patches/zlib/zlib_cmakelists.diff (0 hunks)
  • patches/zlib/zlib_mind_libtype.patch (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@poshul poshul merged commit cedc48c into master Oct 15, 2025
7 of 9 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant