Update - Allow user to edit their submitted photos#532
Open
Update - Allow user to edit their submitted photos#532
Conversation
Collaborator
|
PR looks good to me Sean, I think you really want to add some tests for the main features you're introducing. I'm sure you'll find a bug or two while adding tests 😅 |
Weekly Updates OLM 57
…merchants Add merchant signup
…e-old-data Allow admins update verified tags
merchants page mobile friendly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we want to give users the ability to edit photos they have already submitted.
Trello Card
During BulkTag.vue, there is a new option to filter your photos by
Not Submitted(photo.verified = 0) andVerified(photo.verified = 2).Photos that are in review are not editable yet. Only ones that have been verified are.
Depending on the status that is selected, when the user submits the tags, it will trigger either
AddTagsToPhotoaction orUpdateTagsOnPhotoaction on the backend viaUserPhotoController@bulkTagWith the original
AddTagsToPhotorequest, we used the existing tags, custom tags, and brands, to calculate various XP scores.Before we do anything, we use the existing tags to reverse most of these jobs.
We then delete the existing tags, and re-create the Photo with the new tags, updating everything again from scratch in the process.
Maybe there is a better way to do this. Would like 2nd opinion before moving forward.