Translations update and link to add new language#279
Open
jpablogomezb wants to merge 4 commits intoOpenLitterMap:masterfrom
Open
Translations update and link to add new language#279jpablogomezb wants to merge 4 commits intoOpenLitterMap:masterfrom
jpablogomezb wants to merge 4 commits intoOpenLitterMap:masterfrom
Conversation
Contributor
jpablogomezb
commented
Jul 20, 2021
- Update of some values of the translations.
- Link in the language menu to add a new one.
xlcrr
requested changes
Jul 20, 2021
| "es": { | ||
| "name": "Spain", | ||
| "lang": "Español" | ||
| "lang": "Spanish" |
Member
There was a problem hiding this comment.
We want to keep the original language
| </div> | ||
| <div class="dropdown-item flex"> | ||
| <a href="https://airtable.com/invite/l?inviteId=invooqVMIlQhyHcQy&inviteToken=cc4d36216d5a7a78be587281a080d6a265e81ac258c8c8e118a99ea5568ee02f" target="_blank" | ||
| class="button is-small is-info is-light">Add your language!</a> |
Member
There was a problem hiding this comment.
I am not sure about this tool. I think we might need to build our own tool and give a limited number of people access to it. Maintaining a few json files won't be that hard and it will save us a lot of time going forward
| "name": "UK", | ||
| "lang": "English" | ||
| "name": "Reino Unido", | ||
| "lang": "Inglés" |
Member
There was a problem hiding this comment.
We want to show the language in its original name
| "en": { | ||
| "name": "Engeland", | ||
| "lang": "English" | ||
| "lang": "Engels" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.