fix(net): unable to pass HttpStatusCode#1397
Merged
j2rong4cn merged 2 commits intoOpenListTeam:mainfrom Sep 30, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where HttpStatusCode couldn't be properly passed through error unwrapping by replacing errors.Unwrap with a custom errs.UnwrapOrSelf function that provides fallback behavior.
Key changes:
- Introduces a new
UnwrapOrSelffunction that returns the original error if unwrapping fails - Replaces three instances of
errors.Unwrapwith the new fallback mechanism in HTTP serving logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/net/serve.go | Updated error unwrapping calls to use the new fallback mechanism for proper HTTP status code extraction |
| internal/errs/unwrap.go | Added new utility function that provides fallback behavior when unwrapping errors |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: j2rong4cn <36783515+j2rong4cn@users.noreply.github.com>
Member
Author
|
OpenList/internal/net/request.go Line 128 in 189cebe |
KirCute
approved these changes
Sep 30, 2025
xrgzs
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
错误的使用errors.Unwrap errors.Unwrap并没有fallback机制