Conversation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 88.16% 96.10% +7.94%
==========================================
Files 7 6 -1
Lines 338 334 -4
==========================================
+ Hits 298 321 +23
+ Misses 40 13 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
|
I'll let @jthorton do the proper review here. |
|
@hannahbaumann I see you used openfe's docs as a baseline here, but openfe has a lot of extra bells and whistles that openfe-analysis doesn't need. Could I suggest that you use gufe's docs as a starting point instead? It inherits directly from furo and will work better out-of-the-box. |
atravitz
left a comment
There was a problem hiding this comment.
added some suggestions for cleaning up unneeded code - let me know if there are any items you want to discuss.
Co-authored-by: Alyssa Travitz <31974495+atravitz@users.noreply.github.com>
Co-authored-by: Alyssa Travitz <31974495+atravitz@users.noreply.github.com>
Co-authored-by: Alyssa Travitz <31974495+atravitz@users.noreply.github.com>
Co-authored-by: Alyssa Travitz <31974495+atravitz@users.noreply.github.com>
Co-authored-by: Alyssa Travitz <31974495+atravitz@users.noreply.github.com>
Co-authored-by: Alyssa Travitz <31974495+atravitz@users.noreply.github.com>
Co-authored-by: Alyssa Travitz <31974495+atravitz@users.noreply.github.com>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
atravitz
left a comment
There was a problem hiding this comment.
@hannahbaumann I added docs build to the CI, and it's failing with a few formatting errors. Once those are addressed this is good to go!
No description provided.