Deprecate AD14 (rebasing of #87)#126
Merged
Merged
Conversation
- also remove extra files from other WP cases
31d3f9c to
04235c4
Compare
- also remove .sum files from other UAE cases
86cf87f to
7d53a31
Compare
Note: at some point in the past, maybe around version 3.0, this case was disabled as it did not compare well when run on different platforms. This case was then never updated after `WaveTMax` was reduced from 3630 seconds to 600 seconds. This was done for all offshore cases to memory usage on GH actions (the shorter `WaveTMax` results in different waves). To verify the changes introduced by changing to AD15 were minimal, two comparisons were made. For the first comparison, the original AD14 results with `WaveTMax=3630` were compared with AD15 results also using `WaveTMax=3630`. These results were reasonably close. For the second comparison, a new baseline using AD14 and `WaveTMax=600` was compared against AD15 with `WaveTMax=600` also.
Also remove *.sum and *.log files from other AOC_ cases
30835b3 to
97fc8c3
Compare
97fc8c3 to
49baebb
Compare
NOTE: the Bladed style wind input file does not contain tower information. So the tower shadow in AD15 was turned off
Collaborator
Author
|
Unfortunately rerunning the SWRT cases in FAST7 with However, for the sake of keeping this moving, we will go ahead and merge, then check model differences later. |
…for a while Cases affected: - 5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth - Slight changes in AD loads, and minor changes in SD resulting in very slight changes in the SD reaction loads - hd_5MW_ITIBarge_DLL_WTurb_WavesIrr (Failed) - Time series were shortened, so wave time series are different (driver cases) - hd_5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth - Different grid than in prior runs.
1797484 to
354f39f
Compare
- Simplify 5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth by shortening - Remove unrealistic HD driver cases The hd_5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth and hd_OC3tripod_offshore_fixedbottom_wavesirr cases used a single motion point at the platform reference point. This was mapped rigidly to all structure below, which resulted large motions of the tower bases, which is not the case with the fully coupled fixed bottom case these corresponded to. So we are simply removing these two cases
0e0cc74 to
5891437
Compare
Collaborator
Author
|
@jjonkman will formally review later, and we'll follow up with any corrections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing AD14 and replacing with AD15. This PR supercedes #18 and #87 (both PRs sat for too long and got a bit stale).
This PR also contains updates based on comments in PR #87. This is currently a draft PR; the description will be updated as cases are updated.
The following cases were updated from AD14 to AD15 (see notes below for comparisons):
5MW_ITIBarge_DLL_WTurb_WavesIrrAOC_WStAWT_YFix_WStAWT_YFree_WTurbSWRT_YFree_VS_EDG01SWRT_YFree_VS_EDC01SWRT_YFree_VS_WTurbUAE_Dnwind_YRamp_WStWP_VSP_WTurb_PitchFail5MW_ITIBarge_DLL_WTurb_WavesIrr
Note: at some point in the past, maybe around version 3.0, this case was disabled as it did not compare well when run on different platforms. This case was then never updated after
WaveTMaxwas reduced from 3630 seconds to 600 seconds. This was done for all offshore cases to memory usage on GH actions (the shorterWaveTMaxresults in different waves). To verify the changes introduced by changing to AD15 were minimal, two comparisons were made. For the first comparison, the original AD14 results withWaveTMax=3630were compared with AD15 results also usingWaveTMax=3630. These results were reasonably close. For the second comparison, a new baseline using AD14 andWaveTMax=600was compared against AD15 withWaveTMax=600also. These comparisons are shown above.AOC_WSt
AWT_YFix_WSt
AWT_YFree_WTurb
NOTE: the tower shadow was turned off since the Bladed wind input file did not contain any tower info (regenerating this file results in a different time series).
SWRT_YFree_VS_EDG01
Added tail fin into ED and AD15 for this case (already used AD15).
When FAST8 was introduced, the tail fin option in AeroDyn 15 was not implemented. So this test case has been unstable with AD15 and was turned off. Adding the tail fin from the updated AD15 to the model does not give very good agreement with the FAST7 version of this case (CertTest #15). This is most likely due to missing features in the AeroDyn tail fin, most notably that the
TFinIndMod=1option is not available yet (somewhat related to the FAST7 option ofSubAxIndin the furl file).Despite not matching the FAST7 results very well, we think it best to add this case as is and note that it should be updated when
TFinIndMod=1is available. For later comparison, the Test15 results from FAST7 have been added along with a note about this.OpenFAST devrefers to the OpenFAST dev results prior to this PR, andOpenFAST AD15 tailfinare the new results.SWRT_YFree_VS_EDC01
As with the above case, the match with the FAST7 results is not great due to the missing induction option for the tail fin. Note also that the new results are using the same AeroDyn configuration as the above case (no DBEMT even though the original case had this enabled -- this was done for convenience while debugging the tail fin and can be updated at a later time).
Note: the
FAST7 Test15is really test 16 (incorrect label).OpenFAST AD14 devrefers to the OpenFAST dev results with AD14 prior to this PR, andOpenFAST AD15 tailfinare the new results.SWRT_YFree_VS_WTurb
This regression test roughly follows the expected general trends for the selected channels (not very many channels were common between the original FAST7 test and the current test version). However note that the yaw is different, which may be related to the above notes on the induction for the tail fin.
Note that the shaft torque (
LSShftMxs) doesn't follow as well after including the tail fin.UAE_Dnwind_YRamp_WSt
This test had previously been disabled due to instabilities. With the new AD15, the results are much smoother and follow the same trends as the AD14 results.
WP_VSP_WTurb_PitchFail:
Using the same AD15 input file that the
WP_VSP_WTurbcase uses. This causes some minor differences in the aerodynamic power, thus rotor speed, blade pitch, and other output results changed slightly.