Add unit tests for BD_ComputeIniNodalCrv#636
Merged
Merged
Conversation
| ! -------------------------------------------------------------------------- | ||
| testname = "Tangent aligned with z-axis and 0 degree twist:" | ||
| n = (/ 0.0_BDKi, 0.0_BDKi, 1.0_BDKi /) ! tangent axis | ||
| n = (/ real(0.0, BDKi), real(0.0, BDKi), real(1.0, BDKi) /) ! tangent axis |
Collaborator
There was a problem hiding this comment.
I'm surprised there were any issues with the original code for this line. I can see other lines were missing the _BDKi part, but I'm surprised that writing 0.0_BDKi was problematic.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Add unit tests for checking computation of rotation matrix that accounts for beam curvature and twist in the routine BD_ComputeIniNodalCrvRelated issue, if one exists
Impacted areas of the software
Additional supporting information
Test results, if applicable