beamdyn and orcaflex updates#38
Closed
ghost wants to merge 5 commits into
Closed
Conversation
…r was defined relative to the working directory instead of the directory where the driver input file is located
This forces the use of double over float when compiling in single precision
…bust arithmetic 4 sets of equations should give same results, assuming the "pivot" is not zero. New implementation picks set of equations with largest pivot value, not just one that is slightly larger than 0. (The values are all bounded by 0 and 4 [or less].)
Collaborator
|
I'm closing this pull request without merge as these changes will be included in a subsequent pull request |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates beamdyn_driver and orcaflex_driver with handling for single precision builds. Currently, building in single precision causes compiler errors in these two module drivers due to type mismatches.
Also in this pull request is an update to BD_CrvExtractCrv which improves upon the arithmetic set up in #31.
All of the BeamDyn updates were adapted from @bjonkman's fork at f/Envision-BeamDyn.
The regression test completed with these results:
It is expected that the test case running BeamDyn would have very small changes in the solution. Further investigation reveals that the three failing channels contained negligible differences in the solutions: