Fix format issue preventing fields from appearing in BeamDyn YAML summary file#3366
Merged
Merged
Conversation
…mary file Update AllFmt format strings in BeamDyn_IO.f90 for Init_Nodes and Init_QP arrays to use proper spacing and trailing comma in Fortran format specs. This was preventing writing of this information. Remove redundant format statement from yaml_write_array2R[48]
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes formatting in BeamDyn YAML summary output so that initialization node and quadrature-point fields are written correctly.
Changes:
- Update
AllFmtformat strings used byBeamDyn_IO.f90when writingInit_NodesandInit_QP. - Remove a previously-used
levelindentation prefix on the key/header line inyaml_write_array2R4/2R8(but this introduces an indentation regression whenlevelis used).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| modules/nwtc-library/src/YAML.f90 | Adjusts 2D real-array YAML writer formatting; currently drops header/key indentation when level is provided. |
| modules/beamdyn/src/BeamDyn_IO.f90 | Fixes AllFmt strings used for Init_Nodes_E* and Init_QP_E* YAML output so these arrays are emitted. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
I missed the usage of it right afterwards
luwang00
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
Update
AllFmtformat strings inBeamDyn_IO.f90forInit_NodesandInit_QPwere missing a comma at the end. This was preventing writing of this information.Also removed redundant format statement from yaml_write_array2R[48]Related issue, if one exists
Reported internally
Impacted areas of the software
BeamDyn summary file only
Additional supporting information
It's unclear if this ever worked correctly.
Generative AI usage
Attempted to generate the commit message by ai. It really didn't understand the changes at all.
Test results, if applicable
No changes