update the solution before the convergence criteria control flow#32
Merged
michaelasprague merged 1 commit intoJul 11, 2017
Merged
Conversation
michaelasprague
approved these changes
Jul 11, 2017
michaelasprague
left a comment
Contributor
There was a problem hiding this comment.
The position of this call in the original was clearly in error, and the pull request fixes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modifies
SUBROUTINE BD_DynamicSolutionGA2to update the dynamic quantities before entering the control flow for checking convergence rather than after. Since the convergence control flow returns immediately if the convergence criteria is met, this pull request ensures that the solution will be properly updated during the iteration that reaches convergence.