Bug fixes to C++ API#28
Merged
Merged
Conversation
added 2 commits
May 9, 2017 18:48
… force nodes and interpolation to the Aerodyn nodes
HaymanConsulting
previously requested changes
May 15, 2017
HaymanConsulting
left a comment
Contributor
There was a problem hiding this comment.
We need to avoid using hard-coded file unit numbers in OpenFAST. Please change lines 479, 483, etc. of OpenFOAM.f90 to use file units returned from calls to GetNewUnit() which is in the NWTC_Library
Collaborator
Author
|
Thanks. I have updated the code to use GetNewUnit() in the latest commit. |
sayerhs
approved these changes
May 15, 2017
added 5 commits
May 16, 2017 17:53
… to allow for compilation with older compilers
While OpenFAST does have a restart capability, some of our work is dependent on the use of a third party turbine controller using the Bladed interface. The Bladed interface could have a restart capability, but is not guaranteed to have one. To work around this limitation, the OpenFAST-C++ API will provide a new capability as shown below: When the C++ driver starts from time zero, OpenFAST will start normally and write the velocity data the Aerodyn nodes to a file every time step. When the C++ driver restarts from a non-zero time (time > 0), we have two options 1. trueRestart - All components of FAST including the turbine controller are expected to have a checkpoint file at the specified start time. The C++ driver will call OpenFAST to restart from the checkpoint files at the start time and then proceed to step together with OpenFAST for the rest of the simulation. 2. restartDriverInitFAST - The C++ driver will call OpenFAST to start from scratch (time = 0), read the file containing the velocity data at the Aerodyn nodes, and then step OpenFAST upto the start time of the simulation by applying the velocity data at the Aerodyn nodes. Once OpenFAST reaches the start time of the simulation, the C++ driver and OpenFAST will continue to step together normally while continuing to write out the velocity data the Aerodyn nodes at every time step.
Contributor
|
@ghaymanNREL - any objections to merging? |
Closed
Closed
andrew-platt
referenced
this pull request
in andrew-platt/openfast
Sep 9, 2022
Merge dev into MDv2-farm to update MDv2-farm in preparation for merging into dev for v3.3
psakievich
pushed a commit
to psakievich/openfast
that referenced
this pull request
Oct 26, 2023
Fix typo, and then replace other ratio computations
andrew-platt
added a commit
that referenced
this pull request
Jan 7, 2026
Fix get_elevMinMax function signature to match implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes related to setting of velocity at the actuator force nodes, interpolation of velocity from actuator force to Aerodyn nodes and including the turbine base location in the coordinates returned to the driver program.