Fix bug in ExternalInflow Orientation indexing#2628
Merged
Conversation
29 tasks
andrew-platt
approved these changes
Feb 10, 2025
andrew-platt
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for adding a test as well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
An issue was discovered with the indexing in ExternalInflow which populates the Orientation data that is sent to AMR-Wind. Effectively a
+1was replaced with a_1and instead of throwing a compilation error, this was interpreted as a type specification. This lead to an off-by-one indexing error in the orientation matrices. This PR fixes this issue and adds a new regression test which exercises the ExternalInflow module.Impacted areas of the software
ExternalInflow and regression tests.
Test results, if applicable
New test was added and is passing.