-
Notifications
You must be signed in to change notification settings - Fork 530
Use Cmake OBJECT libraries to create openfastlib and add option to use downloaded reference lapack and blas sources #1010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andrew-platt
merged 28 commits into
OpenFAST:dev
from
Reoptimize-Systems:static-openfast-cmake-obj-libs
Apr 11, 2023
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
e2e2d2b
openfast-cpp/CMakeLists.txt: fixed wrong case on SC.h causes install …
reos-rcrozier a951254
create_FAST_SFunc.m: need linux-specific mex call COMPFLAGS windows o…
reos-rcrozier b009fb7
Merge branch 'main' into dev
reos-rcrozier abcd0a5
Modify build system to create static libopenfast from object librarie…
reos-rcrozier 0ab29c9
More modifying build system to create static libopenfast from object …
reos-rcrozier 0d907d3
Adding more missing target_include_libraries for object libraries
reos-rcrozier 4f4baff
servodyn/CMakeLists.txt: correct servodyn_obj target_link_libraries
reos-rcrozier 6a14d06
Updating CMakeLists to add object libs to install directives to fix e…
reos-rcrozier 2848f6c
top level CMakeLists.txt: add option to use locally built lapack and …
reos-rcrozier b35ce05
Add external lapack as dependency when USE_LOCAL_STATIC_LAPACK option…
reos-rcrozier a164971
supercontroller/CMakeLists.txt: add onject libs to install targets
reos-rcrozier 2a793b4
openfast-library/CMakeLists.txt: remove object libraries from target_…
reos-rcrozier 94fd3a7
top level CMakeLists.txt: install downloaded lapack in src dir, not s…
reos-rcrozier 73614b0
Merge branch 'dev' into static-openfast-cmake-obj-libs
reos-rcrozier 221b250
odifications to cmake files to ensure each object file is built only …
reos-rcrozier c769488
Add missing map library objects to openfast-library
reos-rcrozier 54488a2
openfast-cpp/CMakeLists.txt: add OpenMP target link libs if necessary
reos-rcrozier af56d52
nwtc-library/CMakeLists.txt: put all nwtcsyslib_matlab_obj link libs …
reos-rcrozier 36c4dec
openfast-library/CMakeLists.txt: change order of object files
reos-rcrozier ae106c5
Merge branch 'dev' into static-openfast-cmake-obj-libs
reos-rcrozier 89d8a83
Solved circular nwtclibs versioninfo dependency and
reos-rcrozier 57dfd99
openfast-library/CMakeLists.txt: correct target_link_libraries for op…
reos-rcrozier 8b1bec3
Use object libraries to avoid missing symbol and linking errors in cp…
reos-rcrozier ab0d172
Merge branch 'dev' into static-openfast-cmake-obj-libs
reos-rcrozier 4c73cdc
openfast-cpp CMakeLists.txt: ensure fortran implicit libs are linked
reos-rcrozier 1da89df
Merge branch 'static-openfast-cmake-obj-libs' of github.com:REOptimiz…
reos-rcrozier de00a9e
Restore openfastlib to always be shared
reos-rcrozier b428af5
Added some comments to CMakeFiles.txt
reos-rcrozier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This already happens in
set_fast_fortran()on line 65Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also realised my comment was wrong when I went to examine this. I'm not yet sure what the issue really is, but I think it might be something to do with the fact that the cmake files now separately specify the target libraries and object libraries. Possibly it need to be changed so the target 'real' libraries all use the object libraries, so cmake doesn't attempt to build the same object twice.