HydroDyn summary file nodal data is incorrect when Member is flipped

[ebranlard]

Bug description
The nodal values of the Morison data (R,t, tMG, etc.) listed in the summary file are incorrect when the Member is flipped (HydroDyn flips the members that do not satisfy z_node1<z_node2).

In the summary file output, the code loops on the Nodes, and the Nodes were created before HydroDyn flips the member nodes. If a member is flipped, the loop on the element data of a member will not be in the same order as the nodes.

      do j= 1, numMembers
         do i = 2, members(j)%NElements
            c = c + 1
            pos = nodes(c)%Position
            members(j)%R(i)   ! <<<<< Incorrect if member j is flipped.

One fix could be to N-i+2 instead of i when the member is flipped.
I think it would be even cleaner to loop on the members, and then use member%NodeIndx instead of looping on the nodes.

To Reproduce
Use the HD file enclosed. The summary file displays a radius "R" which decreases with height.

Expected behavior
The radius "R" should increase with height.

OpenFAST Version
dev branch as of 2/4/2022
HD_Flip.txt

[rafmudaf]

@ebranlard could you confirm that this is fixed?

[ebranlard]

This is indeed fixed by the pull request above.