Add RPC service support to the RX pipeline#47
Merged
pavel-kirienko merged 10 commits intomain2from Aug 18, 2023
Merged
Conversation
thirtytwobits
requested changes
Aug 14, 2023
Member
thirtytwobits
left a comment
There was a problem hiding this comment.
Only the comment about the documented ownership model is blocking here. The rest of the comments are minor.
|
Kudos, SonarCloud Quality Gate passed!
|
thirtytwobits
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









This is the final feature.
This changeset slightly modifies the error handling behavior of
udpardRxSubscriptionReceivesuch that the datagram is deallocated if the passed arguments are invalid, unlessselfis also invalid. This is needed to prevent memory leak when the function is invoked incorrectly. An alternative solution is to state it explicitly in the API that the caller is required to free the datagram memory if-UDPARD_ERROR_ARGUMENTis returned, but this convention is comparatively fragile. A new test is added for this.UdpardRxRPCis renamed intoUdpardRxRPCPortfor clarity.UdpardRxRPCDispatcheris extended withlocal_node_idto facilitate destination address check when accepting frames.After this one is accepted, the next steps are: