Merged
Conversation
…to VSCode, and I am not even paid to say that)
… and the remaining few tests pass
thirtytwobits
approved these changes
Jun 30, 2023
Member
thirtytwobits
left a comment
There was a problem hiding this comment.
General comments. Looks good otherwise.
| /// speaking in terms of Berkeley sockets). In the case of redundant interfaces, each socket may need to be configured | ||
| /// to emit data through its specific interface. | ||
| /// | ||
| /// Graphically, the transmission pipeline is arranged as follows: |
Member
There was a problem hiding this comment.
See discussion in chat about what the application should do if one of these tx pipelines fills up but not the other.
Member
Author
|
@lydia-at-amazon @thirtytwobits I updated the docs to try and capture almost all of the issues raised here, and marked the respective threads as resolved. I also added one idea on the future evolution of |
|
Kudos, SonarCloud Quality Gate passed! |
Member
Author
|
As this is approved, I am going to merge this now. Please move unfinished discussions to new issues if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Please focus on the documentation in
udpard.h. The other changes are trivial and can be ignored.Changes: