Skip to content

Service Responses do not have Node ID (but must) in Multicast IP Address #21

@emrainey

Description

@emrainey

In txMakeServiceSessionSpecifier, the Node ID is not being set in the function, resulting in responses being sent to the wrong Multicast IP address.

From https://github.com/OpenCyphal-Garage/libudpard/blob/main/libudpard/udpard.c#L259

((UdpardIPv4Addr) UDPARD_NODE_ID_MASK & (UdpardIPv4Addr) service_id)) | should be ((UdpardIPv4Addr) UDPARD_NODE_ID_MASK & (UdpardIPv4Addr) src_node_id)) |

But this call to construct Service Multicast IP address needs to use the remote Node ID, not the local Node ID.
https://github.com/OpenCyphal-Garage/libudpard/blob/main/libudpard/udpard.c#L299

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions