Add missing help-discover template to base theme#1968
Open
kayjoosten wants to merge 1 commit intomainfrom
Open
Add missing help-discover template to base theme#1968kayjoosten wants to merge 1 commit intomainfrom
kayjoosten wants to merge 1 commit intomainfrom
Conversation
The /authentication/idp/help-discover route was throwing a generic exception for any theme other than openconext because the template only existed in theme/openconext/ but not in theme/base/ as a fallback. The Twig @theme namespace resolves active theme first, then falls back to base — adding the template there fixes the broken help button on the WAYF screen for all non-openconext themes. Fixes #1881
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /authentication/idp/help-discover route was throwing a generic exception for any theme other than openconext because the template only existed in theme/openconext/ but not in theme/base/ as a fallback.
The Twig @theme namespace resolves active theme first, then falls back to base — adding the template there fixes the broken help button on the WAYF screen for all non-openconext themes.
Fixes #1881