[typescript-axios] / #12828: Add ESM support to typescript-axios client#13586
Conversation
|
This is my first time contributing to open source 🙇♀️ About the following step ⬇️
After running the first command there are some errors, but they are related to the Python client 🤔 When generating samples I also got an error T_T I am sorry, Java is not my first language. |
|
😍 😍 😍 😍 |
|
UPDATE I was able to create the JAR file using the following command that skips tests and successfully generated samples 👍 |
macjohnny
left a comment
There was a problem hiding this comment.
thanks for your contribution!
|
@macjohnny About removing I have successfully build and tested out TS clients on my local 👍 |


fix #12828
An additional tsconfig.esm.json is added to every generated typescript-axios code having supportsES6 and npmName.
That will create an additional ECMAScript Module (ESM) to the npm build.
I used similar PR for
typescript-fetchclient as reference #11720PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.1.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka