Skip to content

[PHP] Allow strings with only whitespaces in enums #12783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 1 commit into from
Jul 11, 2022
Merged

[PHP] Allow strings with only whitespaces in enums #12783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...penapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractPhpCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,6 +664,10 @@ public String toEnumVarName(String name, String datatype) {
return "EMPTY";
}

if(name.trim().length() == 0) {
return "SPACE_" + name.length();
}

// for symbol, e.g. $, #
if (getSymbolName(name) != null) {
return (getSymbolName(name)).toUpperCase(Locale.ROOT);
Expand Down Expand Up @@ -739,6 +743,11 @@ public String escapeText(String input) {
return input;
}

// If the string contains only "trim-able" characters, don't trim it
if(input.trim().length() == 0) {
return input;
}

// Trim the string to avoid leading and trailing spaces.
return super.escapeText(input).trim();
}
Expand Down