Skip to content

Document all used vendor extensions in specific generator#11797

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
borsch:document-all-vendor-extensions
Mar 6, 2022
Merged

Document all used vendor extensions in specific generator#11797
wing328 merged 1 commit into
OpenAPITools:masterfrom
borsch:document-all-vendor-extensions

Conversation

@borsch

@borsch borsch commented Mar 4, 2022

Copy link
Copy Markdown
Member

Describe vendor extensions used by specific generator

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@borsch borsch requested a review from jimschubert as a code owner March 4, 2022 15:38
@borsch borsch force-pushed the document-all-vendor-extensions branch from b40cd76 to 38b93f6 Compare March 4, 2022 15:57
@wing328

wing328 commented Mar 6, 2022

Copy link
Copy Markdown
Member

Thanks for the PR.

cc @OpenAPITools/generator-core-team

@cachescrubber

Copy link
Copy Markdown
Contributor

LGTM

@wing328 wing328 merged commit 382e2a2 into OpenAPITools:master Mar 6, 2022
@borsch borsch deleted the document-all-vendor-extensions branch March 6, 2022 17:55

@welshm welshm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants