Skip to content

[TypeScript] Fix type array with uniqueItems#11515

Merged
macjohnny merged 6 commits into
OpenAPITools:masterfrom
ty-v1:fix-typescript-unique-array-bug
Feb 4, 2022
Merged

[TypeScript] Fix type array with uniqueItems#11515
macjohnny merged 6 commits into
OpenAPITools:masterfrom
ty-v1:fix-typescript-unique-array-bug

Conversation

@ty-v1

@ty-v1 ty-v1 commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

resolve #10174.

This PR fixes typescript generator so that it does not generate import of Set when an array with uniqueItems exists.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

@macjohnny macjohnny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@macjohnny macjohnny merged commit 7843a45 into OpenAPITools:master Feb 4, 2022
@macjohnny macjohnny added this to the 6.0.0 milestone Feb 4, 2022
@ty-v1 ty-v1 deleted the fix-typescript-unique-array-bug branch February 4, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][TYPESCRIPT] type array with uniqueItems generates import of Set

2 participants