updates to swagger-parser 2.0.28#10819
Conversation
|
I believe the build failure to be transient network issues but don't have permission to re-run it. |
| nullable: true | ||
| type: string | ||
| nullableWithNullDefault: | ||
| default: "null" |
There was a problem hiding this comment.
@benzvan thanks for the PR. Is this a regression? Did the changelog mention anything related to this change?
There was a problem hiding this comment.
That must have crept in when I ran the generator scripts. I didn't notice any output related to it.
There was a problem hiding this comment.
Though reading it maybe it's just being more explicit? Seems like it's reasonable for a nullableWithNullDefault to have a default of null
There was a problem hiding this comment.
I'm not familiar enough with the upstream project to speak intelligently to the change though. I just know it used to use a 4-year-old version of httpclient. :-D
There was a problem hiding this comment.
@wing328 any followup thoughts? The only line I manually changed was the version number for swagger-parser.
There was a problem hiding this comment.
Poking around the swagger-parser notes I see this could be related but I don't know enough about the code to be sure.
https://github.com/swagger-api/swagger-parser/pull/1600/files
Updates swagger parser to mitigate vulnerability in dependent httpclient library.
#10818
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x