[BUG] Empty schema not working anymore since v5.3.0

[ramondeklein]

Suppose I have a method that accepts any input in the body:

---
openapi: 3.0.1
info:
  title: TEST
  version: v1
servers:
- url: http://localhost/
paths:
  "/":
    put:
      operationId: test
      parameters: []
      requestBody:
        content:
          application/json:
            schema: {}
      responses:
        '204':
          description: Success

When using the typescript-angular converter, this resulted in the following method in default.service.ts (using v5.2.1):

public test(body?: any, observe?: 'body', reportProgress?: boolean, options?: {httpHeaderAccept?: undefined}): Observable<any>;

When using v5.3.0 the following method is generated:

public test(UNKNOWN_PARAM_NAME?: , observe?: 'body', reportProgress?: boolean, options?: {httpHeaderAccept?: undefined, context?: HttpContext}): Observable<any>;

No warnings are issued during code-generation and it's not related to the Typescript generator, because it also generates similar code for the C# and Java generators (all invalid syntax).

[ramondeklein]

A workaround is to use a schema that look like this:

---
openapi: 3.0.1
info:
  title: TEST
  version: v1
servers:
- url: http://localhost/
paths:
  "/":
    put:
      operationId: test
      parameters: []
      requestBody:
        content:
          application/json:
            schema:
              type: object
      responses:
        '204':
          description: Success

This schema is more appropriate and also ensure that everything is working with most v5.3.0+ generators again. A notable exception is the TypeScript generator, because it now generates type object instead of any.

[ramondeklein]

I would prefer to have the situation from v5.2.1 back again. I guess it was introduced with PR #10334 where there are a lot of changes regarding to any types have been made.

@spacether Could you check if this is related?

[spacether]

Thank you for reporting this; I have a PR to fix it in the works; waiting for tests to pass on it now

[spacether]

@ramondeklein can you rebase on master and see if my merged fix solves the issue for you?

[ramondeklein]

@spacether I won't be back in the office until Wednesday, so it may take a while to check.

[ramondeklein]

@spacether It now generates a proper body?: any again, so this seems to be fixed. Thanks for fixing this. 👍🏻

[ryan-token]

@spacether I am seeing that UNKNOWN_PARAM_NAME issue again on v7.1.0. Version 6.6.0 does not have this problem. Building for a Swift 5 application.

[spacether]

I am no longer contributing to this project. Please reach out to active maintainers in github or Slack for help with this.

[ryan-token]

Whoops, sorry about that. @wing328 are you the right person to flag for this UNKNOWN_PARAM_NAME issue?

[wing328]

please open a new issue with details (e.g. spec) for tracking.

[edvinasstaupas]

@r-token have you opened a new issue or found a fix for this?

[ryan-token]

@edvinasstaupas I have not. My team switched over to using the Java-based openapi-generator-cli instead to work around this problem. Unsure if it is still an issue in later versions after v7.1.0.